Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko]: fix typo in Array.from() reference #16606

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[ko]: fix typo in Array.from() reference #16606

merged 1 commit into from
Oct 20, 2023

Conversation

omins
Copy link
Contributor

@omins omins commented Oct 17, 2023

Description

Fix typo in Array.from() reference.

  • "전체 배열 없어" -> "전체 배열 없이"

Motivation

  • Found typo while reading the docs.
  • It seems make sense when "없어" has changed to "없이"

Additional details

Related issues and pull requests

@omins
ko: fix typo of Array.from()
7a626ef 
* 전체 배열 없어 -> 전체 배열 없이
@omins omins requested a review from a team as a code owner October 17, 2023 06:14
@omins omins requested review from wisedog and removed request for a team October 17, 2023 06:14
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Oct 17, 2023
wisedog
wisedog approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisedog wisedog merged commit 1c210e8 into mdn:main Oct 20, 2023
6 checks passed
@github-actions
Copy link
Contributor

Preview URLs

Flaws (3)

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Array/from
Title: Array.from()
Flaw count: 3

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Set does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/from does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/from
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/from does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisedog wisedog wisedog approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omins @wisedog